Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance(main/luarocks): use termux-elf-cleaner to clean bin #20568

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

enhance(main/luarocks): use termux-elf-cleaner to clean bin #20568

wants to merge 2 commits into from

Conversation

cattokomo
Copy link
Contributor

Closes #20566

@cattokomo
enhance(main/luarocks): use termux-elf-cleaner to clean bin
7bd5aff 
execute termux-elf-cleaner on binaries and C modules
@tqfx
Copy link
Contributor

tqfx commented Jun 17, 2024

luarocks --verbose install luaprompt does not work, building on the device does not require executing termux-elf-cleaner.

@Grimler91
Copy link
Member

luarocks --verbose install luaprompt does not work

That is unrelated to this PR I guess?

building on the device does not require executing termux-elf-cleaner

Might be some android versions where it is still useful, does not hurt in any case

@tqfx
Copy link
Contributor

tqfx commented Jun 20, 2024

What I mean is that when executing termux-elf-cleaner make sure that this file is an ELF file.

@Grimler91
Copy link
Member

@tqfx Ah, right, good point!

@cattokomo
Copy link
Contributor Author

@tqfx termux-elf-cleaner will run smoothly regardless if the file is ELF or not.

@cattokomo @tqfx
fix syntax
4361682 
Co-authored-by: tqfx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tqfx tqfx tqfx left review comments

@finagolfin finagolfin Awaiting requested review from finagolfin finagolfin is a code owner

@Grimler91 Grimler91 Awaiting requested review from Grimler91 Grimler91 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make luarocks to execute termux-elf-cleaner on post building C modules/binaries.
3 participants
@cattokomo @tqfx @Grimler91