Update errors coding style #7485
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `github.com/pkg/errors` package is deprecated and archived. Update the style guide to follow Go standard style for `error` type wrapping. Signed-off-by: SuperQ <[email protected]>
|
So I think we discussed this previously at some point in #5176 and came up with a custom error package in #5239 which we then moved to https://github.com/efficientgo/core/tree/main/errors. I did some work to port the promql-engine to this new error package in thanos-io/promql-engine#134 and there was some work to do the same for Thanos in #5382 Do you think we should continue this effort or maybe rely on default Go semantics? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The
github.com/pkg/errorspackage is deprecated and archived. Update the style guide to follow Go standard style forerrortype wrapping.Verification