Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow label to be any type that impl IntoView #203

Closed
wants to merge 1 commit into from

Conversation

heyjul
Copy link

@heyjul heyjul commented May 29, 2024

@heyjul
Copy link
Author

heyjul commented May 29, 2024

I see that the builds fails, I will try to fix that later today

@luoxiaozero
Copy link
Collaborator

I think the build failed because it was a breaking change.

@heyjul
Copy link
Author

heyjul commented May 29, 2024

Yes it is indeed.
I thought that it would not be a breaking change since String implements the necessary traits and since the type can be inferred but I didn't think about return types of a function.
Now that I think about it, it will probably be a problem even when no options are passed down to the AutoComplete.

Since it is a breaking change, is it still a desired change ?

@heyjul
Copy link
Author

heyjul commented Jun 1, 2024

Can't think of a way to implement this.

@heyjul heyjul closed this Jun 1, 2024
@luoxiaozero
Copy link
Collaborator

I will change it in version 0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants