Add dummy desk files for testing #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate of #13. |
|
@bonbud-macryg Not a duplicate; one is for |
bonbud-macryg
requested changes
May 18, 2024
| cp -rfL ${RESOURCE_DIR}/* ${INSTALL_DIR}/ | ||
| DOCKET_FILE="${INSTALL_DIR}/desk.docket-0" | ||
|
|
||
| echo "\n" >> $DOCKET_FILE |
There was a problem hiding this comment.
Had to change to this to get it working on macOS, otherwise it added the text \n in there.
echo "" >> $DOCKET_FILEThere was a problem hiding this comment.
Not sure why this didn't come up testing #13. I just tried installing with -k on a new fakeship working from the develop branch and got this in there too.
:~
title+'Chess'
info+'Fully peer-to-peer chess over Urbit'
color+0xff.ffff
image+'https://peekabooo.icu/images/finmep-chess.svg'
base+'chess'
version+[0 0 1]
license+'GPL3'
website+'https://github.com/thecommons-urbit/chess'\n
glob-ames+[~fun 0v0]
==There was a problem hiding this comment.
So odd - I tested it locally, and my test file didn't have this issue
There was a problem hiding this comment.
Could be an OS thing. Does it make a difference in Linux if you replace the "\n" with ""?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some dummy files needed to publish
%chessas an app using Landscape, as well as a-koption to the install script that will fill in their blanks and copy them over into the test ship's pier.