Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/allow touch scroll #13

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

halimb
Copy link

@halimb halimb commented Jan 30, 2019

Pull Request

Fixes: Any idea to add scroll?

Solution: add an option 'enableTouchScroll' (default to false), which will only proceed with drag behaviour if the distance travelled horizontally (in case of right and left slidePanels) is greater than the vertical one (scroll), and vice versa.

PS: I didn't make a feature request beforehand, the reason being I wrote this code to solve an issue with another project, and later thought it might be good to have it in the main library

Changes proposed:

  • Add: possibility to touch scroll in a slidePanel
  • Fix
  • Remove
  • Update

@quentinboinet
Copy link

Hello halimb,
I've found myself stuck with the same problem, no scroll and links weren't working on the side panel on mobile device.
Thanks to your feature and contribution now it's working like a charm !
Don't know if this repo is still maintained but it should definitely be merged.

@halimb
Copy link
Author

halimb commented Mar 2, 2022

Hi @quentinboinet
I'm glad it helped. Thanks for the feedback.
The repo seems to be abandoned, I didn't get any feedback from the authors since then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants