-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Basic Interfaces and CI/CD for web interface #212
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
@FanwangM I noticed the workflow failed during docker build stage. It looks like there were some problem after we bump the python version to 3.11. I fixed it with using the convention of 3.11 of Also, I think it might be beneficial if you can set up the dockerhub and HuggingFace credential in the repo's secrets. Otherwise the workflow will not work because it depends on the secrets of the repo, which our official repo haven't set up yet. |
There was also 2 places I would appreciate your opinion too. Could you let me know if it's okay for me to use these approches: |
For now, I think we can focus on the web app itself and then we will deal with the docker image later. We can just comment on the related part. We may end up hosting the docker images with Can you update the codes based on https://huggingface.co/spaces/QCDevs/selector? |
Hi @FanwangM, thank you for the comment! That makes sense since this way the user can stay on our Github page to get the docker image without going to another site. I will also take a look at how to make this work too basides working on other interfaces. We can discuss this in our next meeting too since it looks like there are somewhat more setup for publishing images on Github. I will update the workflow to push it to our official space. However, I noticed that the space you created is a Also, could you set the Let me know if there is any questions~ |
The space has been converted to a |
Hi @FanwangM, I commented out the code in the workflow for building and pushing docker image. I also updated the command for pushing to HuggingFace. Could you run the workflow again to see if it works? I think it should work now. |
Hi @FanwangM ,I figured that we should use |
This is a good and important point! Thanks for bringing it up. We should have this on the to-do list. |
Hi @FanwangM, I noticed the pushing to HuggingFace is still failing for some reason. Just curious, did you setup the You can refer to this tutorial for how to generate the access token up if you haven't already. We also need to give all the necessary permissions to the token such as write access etc to allow our github action to be able to push. |
Thanks for checking this. But I did set up the Did you successfully deployed the application from your end using your own HF account before? |
Yes. I just deployed another version on my own space minutes ago. Did you set it up as |
We have |
This PR introduces the basic interfaces of our package, including the
intro
andMaxMin
page. Moreover, it established a complete CI/CD protocol to deploy the associated docker image toDockerHub
andHuggingFace
for deployment.The docker image is deployed on DockerHub.
The application is live on HuggingFace.
There are a few things that should be checked before merging:
Here is a demo of this PR:
Demo.mp4