Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadth-first search #36

Merged
merged 16 commits into from
Sep 26, 2018
Merged

Breadth-first search #36

merged 16 commits into from
Sep 26, 2018

Conversation

shsr04
Copy link

@shsr04 shsr04 commented Sep 11, 2018

This solves the BFS problem for a graph G=(V,E).

  • Time: O(n+m)
  • Space: O(n) bits

@coveralls
Copy link

coveralls commented Sep 12, 2018

Coverage Status

Coverage increased (+0.9%) to 77.15% when pulling 25c43db on shsr04:bfs into 368951b on thm-mni-ii:master.

@shsr04 shsr04 changed the title Breadth-first search [WIP] Breadth-first search Sep 18, 2018
@shsr04 shsr04 requested a review from dppl September 19, 2018 13:46
@shsr04
Copy link
Author

shsr04 commented Sep 19, 2018

Did I break something?

@shsr04 shsr04 mentioned this pull request Sep 19, 2018
Copy link
Collaborator

@dppl dppl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will look further into it.

@shsr04 shsr04 changed the title [WIP] Breadth-first search Breadth-first search Sep 24, 2018
@andrej-sajenko
Copy link
Member

Hi @shsr04, can you tell me why you disabled the tests in this pull request?
Recall your last commit message: 'disable CD iterator test for now'

@shsr04
Copy link
Author

shsr04 commented Sep 25, 2018

The test is failing for unknown reasons (see #31). @dappels can not reproduce the error, so I think the test is not useful.

@dppl
Copy link
Collaborator

dppl commented Sep 25, 2018

As @shsr04 said I was not able to reproduce the error locally with the current master version.
However even after cloning his branch and running the test I'm still not able to reproduce the problem.

The error also does not seem to be related to the fixed seed, which is used to shuffle the test set in order to fill the words in an unordered way.

Could the error be somehow related to different clang versions?

@shsr04
Copy link
Author

shsr04 commented Sep 25, 2018

I have tried with g++ 6.3.0 and clang++ 3.8, both give the same error.

@andrej-sajenko andrej-sajenko merged commit 05df818 into thm-mni-ii:master Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants