Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update Gradle wrapper validation action #38

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

benny123tw
Copy link
Contributor

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description, Motivation, and Context

Updated the CI job to use gradle/actions/wrapper-validation@v3 instead of the deprecated gradle/wrapper-validation-action@v3.

This change is required because gradle/wrapper-validation-action@v3 has been superseded by gradle/actions/wrapper-validation@v3. Updating ensures we are using the latest supported action.

See https://github.com/gradle/wrapper-validation-action/blob/main/README.md
Also see the warning messages from CI/CD jobs: https://github.com/thriving-dev/java-library-template/actions/runs/9406291395

πŸ§ͺ How Has This Been Tested?

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Updated the CI job to use gradle/actions/wrapper-validation@v3 instead of the deprecated gradle/wrapper-validation-action@v3.
Copy link
Contributor

@hartmut-co-uk hartmut-co-uk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @benny123tw, thanks for the contribution!
There's one more change required. It's confusion ... action action action! πŸ˜†

.github/workflows/callable.build.yml Outdated Show resolved Hide resolved
@benny123tw
Copy link
Contributor Author

Hi @hartmut-co-uk, thanks for reviewing this PR.
I've pushed a new commit to fix the issue.

@hartmut-co-uk
Copy link
Contributor

Perfect, thanks!

@hartmut-co-uk hartmut-co-uk merged commit 385c6a3 into thriving-dev:main Jun 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants