feat: refactor thu-info-lib/src/util/srunCrypto #570
+128
−126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for taking time to contribute! 🎉
Before we move on, fill out the template so that we can better understand your contribution.
What is the purpose of this PR?
Is there a related issue?
no
Please describe your changes.
This pr is aimed to prune and clarify the code in the
thu-info-lib/src/util/srunCrypto
file. And i just provide the minimal requirement for the srun network. (if you want a class with encode/decode, please uncomment the rest part, or you can just remove that)Are there any possible drawbacks or side-effects?
no, i think
How to verify the changes?
with unit tests, and i'm just refactor the code :)
as a windows user, i haven't made sense of how to test it🤧, maybe a more useful guide is needed.
but i have test the relevant changes on other project, see here. hint that the expected outputs are the same as the origin code, and the base64 decode part will always break the test file (maybe unexpected eof) so i only make test for xEncode and base64encode. All the tests / typecheck are passed.
For i only make units test for the changed part, code review is needed for further tests.