Don't warning build non Kprobes #463
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KernelSU work without Kprobes Tested on kernel xiaomi linux 4.19
![cr-gpt[bot]](https://avatars.githubusercontent.com/in/292659?s=60&v=4){kind=small}
tiann
requested changes
May 12, 2023
| @@ -56,7 +58,7 @@ int __init kernelsu_init(void) | |||
| #ifdef CONFIG_KPROBES | |||
| ksu_enable_sucompat(); | |||
| ksu_enable_ksud(); | |||
| #else | |||
| #elif LINUX_VERSION_CODE < KERNEL_VERSION(4, 19, 0) | |||
There was a problem hiding this comment.
Can we remove the condition, and make the warning a info?
There was a problem hiding this comment.
Ya bro.. maybe that's better..
I tried on linux
- 4.9.x
- 4.14.x
- 4.19.x
without kprobes, and KSU runs normally too
And this method will help kernels that have corrupted kprobes to run KSU without kprobes
There was a problem hiding this comment.
4.9 and 4.14 should also work without kprobes, so we shouldn't warn them, too.
|
I will close this since it is stale, welcome to make another PR in any time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KernelSU work without Kprobes
Tested on kernel xiaomi linux 4.19