Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg: add time window package #7231

Merged
merged 4 commits into from
Oct 20, 2023

Conversation

CabinfeverB
Copy link
Member

What problem does this PR solve?

Issue Number: ref #7167 close #7230

What is changed and how does it work?

this PR is based on https://github.com/go-kratos/aegis/tree/main/internal/window.
Add some test and remove some useless code.

Check List

Tests

  • Unit test

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Signed-off-by: Cabinfever_B <[email protected]>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 19, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 19, 2023
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #7231 (477c96a) into master (8b2896b) will decrease coverage by 0.20%.
Report is 8 commits behind head on master.
The diff coverage is 89.65%.

❗ Current head 477c96a differs from pull request most recent head e6629a1. Consider uploading reports for the commit e6629a1 to get more accurate results

@@            Coverage Diff             @@
##           master    #7231      +/-   ##
==========================================
- Coverage   74.65%   74.45%   -0.20%     
==========================================
  Files         442      446       +4     
  Lines       47744    48132     +388     
==========================================
+ Hits        35642    35839     +197     
- Misses       8957     9139     +182     
- Partials     3145     3154       +9     
Flag Coverage Δ
unittests 74.45% <89.65%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 20, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 20, 2023
@nolouch
Copy link
Contributor

nolouch commented Oct 20, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 20, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 20, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 477c96a

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 20, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 20, 2023

@CabinfeverB: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 1899f41 into tikv:master Oct 20, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sliding Time window
3 participants