ratelimit: support modify BBR config by API #7291
Open
+1,441
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
rleungx
reviewed
Nov 9, 2023
pkg/ratelimit/controller.go
Outdated
| @@ -0,0 +1,87 @@ | |||
| // Copyright 2022 TiKV Project Authors. | |||
There was a problem hiding this comment.
Suggested change
| // Copyright 2022 TiKV Project Authors. | |
| // Copyright 2023 TiKV Project Authors. |
pkg/ratelimit/limiter.go
Outdated
Comment on lines
71
to
72
| l.mu.RLock() | ||
| defer l.mu.RUnlock() |
| h.rd.JSON(w, http.StatusOK, result) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| func getQPSSetting(input map[string]interface{}, cfg *ratelimit.DimensionConfig) bool { | ||
| qps, ok := input["qps"].(float64) |
There was a problem hiding this comment.
How about moving it to the caller or merging the getxxxSetting?
pkg/ratelimit/option.go
Outdated
| return func(label string, l *Limiter) UpdateStatus { | ||
| // UpdateDimensionConfigForTest creates QPS limiter and concurrency limiter for a given label by config if it doesn't exist. | ||
| // only used in test. | ||
| func UpdateDimensionConfigForTest(cfg *DimensionConfig, opt ...bbrOption) Option { |
There was a problem hiding this comment.
Is there any difference with line 77? Can we just use this one?
Signed-off-by: Cabinfever_B <[email protected]> address comment Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
ti-chi-bot
bot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
ti-chi-bot
bot
added
the
do-not-merge/work-in-progress
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7291 +/- ##
==========================================
+ Coverage 73.45% 73.53% +0.07%
==========================================
Files 432 433 +1
Lines 47886 48123 +237
==========================================
+ Hits 35175 35387 +212
- Misses 9667 9683 +16
- Partials 3044 3053 +9
Flags with carried forward coverage won't be shown. Click here to find out more. |
CabinfeverB
removed
the
needs-rebase
ti-chi-bot
bot
removed
the
do-not-merge/work-in-progress
ti-chi-bot
bot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #7167
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs/pingcap/docs-cn:pingcap/tiup:Release note