Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to operator-sdk version v1.28.1 #24

Merged
merged 1 commit into from
May 10, 2023
Merged

Update to operator-sdk version v1.28.1 #24

merged 1 commit into from
May 10, 2023

Conversation

mihkulemin
Copy link
Contributor

  • Test suite migrated to Ginkgo v2.
  • Proper termination of testenv in test suite.
  • Operator reconsiliation function signature changed: context is the parameter now.

@mihkulemin
Update to operator-sdk version v1.28.1
8cd848f 
- Test suite migrated to Ginkgo v2.
- Proper termination of testenv in test suite.
- Operator reconsiliation function signature changed: context is the
  parameter now.
timoha
timoha approved these changes May 10, 2023
View reviewed changes
Copy link
Owner

@timoha timoha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dethi
dethi approved these changes May 10, 2023
View reviewed changes
Copy link
Collaborator

@dethi dethi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pidren pidren merged commit 8a814c9 into timoha:main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timoha timoha timoha approved these changes

@dethi dethi dethi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mihkulemin @timoha @dethi @pidren