Merge pull request #50 from invakid404/main

fix(frontend): add `rel="external"` to external links
toboshii · Oct 3, 2022 · 1d21ef0 · 1d21ef0
2 parents 618cbba + dead4f0
commit 1d21ef0
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/frontend/src/lib/AppList/AppGroup.svelte b/frontend/src/lib/AppList/AppGroup.svelte
@@ -18,7 +18,7 @@
         animate:flip={{ duration: 300 }}
     >
         <div class="apps_icon">
-            <a href={app.url} target="{(app.targetBlank || targetBlank) ? '_blank' : null}" rel="noopener noreferrer">
+            <a href={app.url} target="{(app.targetBlank || targetBlank) ? '_blank' : null}" rel="external noopener noreferrer">
                 {#if app.icon.includes("//")}
                     <img src={app.icon} alt="app icon for {app.name}" />
                 {:else if app.icon.includes(":") || !app.icon}
@@ -38,7 +38,7 @@
             {/if}
         </div>
         <div class="apps_text">
-            <a href={app.url} target="{(app.targetBlank || targetBlank) ? '_blank' : null}" rel="noopener noreferrer">{app.name}</a>
+            <a href={app.url} target="{(app.targetBlank || targetBlank) ? '_blank' : null}" rel="external noopener noreferrer">{app.name}</a>
             {#if showUrl}
                 <span class="app_address">{app.url}</span>
             {/if}

diff --git a/frontend/src/lib/BookmarkList/BookmarkGroup.svelte b/frontend/src/lib/BookmarkList/BookmarkGroup.svelte
@@ -9,7 +9,7 @@
         <a
             href={link.url}
             target={link.targetBlank || targetBlank ? "_blank" : null}
-            rel="noopener noreferrer"
+            rel="external noopener noreferrer"
         >
             {#if link.icon}
                 {#if link.icon.includes("//")}

diff --git a/frontend/src/lib/Modal/Modal.svelte b/frontend/src/lib/Modal/Modal.svelte
@@ -115,7 +115,7 @@
                             ><a
                                 href={provider.url}
                                 target="_blank"
-                                rel="noopener noreferrer"
+                                rel="external noopener noreferrer"
                                 ><Icon icon={provider.icon} inline />
                                 {provider.name}</a
                             ></td
@@ -149,17 +149,17 @@
         <a
             href="https://github.com/toboshii/hajimari"
             target="_blank"
-            rel="noopener noreferrer"><Icon icon="mdi:github-box" /></a
+            rel="external noopener noreferrer"><Icon icon="mdi:github-box" /></a
         >
         <a
             href="https://discord.gg/HWGZSWJsA8"
             target="_blank"
-            rel="noopener noreferrer"><Icon icon="mdi:discord" /></a
+            rel="external noopener noreferrer"><Icon icon="mdi:discord" /></a
         >
         <a
             href="https://icon-sets.iconify.design"
             target="_blank"
-            rel="noopener noreferrer"><Icon icon="mdi:material-design" /></a
+            rel="external noopener noreferrer"><Icon icon="mdi:material-design" /></a
         >
         <button
             on:click={handleSave}

diff --git a/frontend/src/routes/+error.svelte b/frontend/src/routes/+error.svelte
@@ -34,10 +34,10 @@
             {/if}
 
             <p>
-                If the error persists, please drop by the <a target="_blank" rel="noopener noreferrer" href="https://discord.gg/HWGZSWJsA8">Discord</a
+                If the error persists, please drop by the <a target="_blank" rel="external noopener noreferrer" href="https://discord.gg/HWGZSWJsA8">Discord</a
                 >
                 and let us know, or raise an issue on
-                <a target="_blank" rel="noopener noreferrer" href="https://github.com/toboshii/hajimari/issues/new/choose">GitHub</a>. Thanks!
+                <a target="_blank" rel="external noopener noreferrer" href="https://github.com/toboshii/hajimari/issues/new/choose">GitHub</a>. Thanks!
             </p>
         {/if}
     </section>