fix(teradata): use timestamp with time zone over timestamptz #3723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…timestamp fix. cloes 3722
mtagle
changed the title
|
please run make style, thank you very much for your pr |
|
when I run what am I missing? |
georgesittas
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Hey @mtagle
when I run
make style, even on a clean master, I get this:pre-commit run --all-files make: pre-commit: No such file or directory make: *** [style] Error 1what am I missing?
It looks to me like you don't have pre-commit installed. Can you first try make install-dev, then install-pre-commit and then run make style again?
|
I'll take this one to the finish line, thanks for the PR :-) |
|
Slightly refactored this while I was at it, take a look here - 84416d2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes 3722
after making the change,
current_timestampin my example sql no longer retained it's precision. I'm not sure why this happened but modifying the current timestamp transform seemed to fix it.regarding this change: current_timestamp can have a precision of 0-6, but
current_timestamp()(with no arguments) is not valid sql.documentation reference: https://docs.teradata.com/r/Enterprise_IntelliFlex_VMware/SQL-Functions-Expressions-and-Predicates/Built-In-Functions/CURRENT_TIMESTAMP/CURRENT_TIMESTAMP-Function-Syntax so I tried to represent this in the transform