Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable eslint-plugin-react-compiler #7067

Draft
wants to merge 1 commit into
base: xp/05-17-try_react_compiler
Choose a base branch
from

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented May 26, 2024

The eslint-plugin-react-compiler identifies several anti-patterns. I attempted to fix some of them but struggled to find simple one-liner solutions.

Copy link

graphite-app bot commented May 26, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented May 26, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added test Related to test cases app:core labels May 26, 2024
Copy link

nx-cloud bot commented May 26, 2024

@pengx17 pengx17 marked this pull request as ready for review May 26, 2024 03:49
@pengx17 pengx17 marked this pull request as draft May 26, 2024 03:49
Copy link

codecov bot commented May 26, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 67.18%. Comparing base (68cf451) to head (54d93a4).

Files Patch % Lines
...-workspace-list/workspace-list/component/index.tsx 25.00% 3 Missing ⚠️
...core/src/modules/workbench/view/workbench-root.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           xp/05-17-try_react_compiler    #7067   +/-   ##
============================================================
  Coverage                        67.18%   67.18%           
============================================================
  Files                              585      585           
  Lines                            28732    28731    -1     
  Branches                          2593     2593           
============================================================
  Hits                             19303    19303           
+ Misses                            9158     9157    -1     
  Partials                           271      271           
Flag Coverage Δ
server-test 77.74% <ø> (ø)
unittest 39.34% <16.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

1 participant