-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): new quick search service #7214
base: eyhn/feat/t_split_split
Are you sure you want to change the base?
Conversation
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0bc1be3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
8033500
to
bf79a6a
Compare
a775505
to
96ab490
Compare
bf79a6a
to
99c54b6
Compare
96ab490
to
1f9b0ef
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## eyhn/feat/t_split_split #7214 +/- ##
===========================================================
- Coverage 58.32% 57.29% -1.04%
===========================================================
Files 873 897 +24
Lines 38707 39372 +665
Branches 4280 4423 +143
===========================================================
- Hits 22575 22557 -18
- Misses 15779 16468 +689
+ Partials 353 347 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
99c54b6
to
5808f09
Compare
1f9b0ef
to
63f8441
Compare
5808f09
to
8783742
Compare
63f8441
to
0d0f361
Compare
8783742
to
e4cc638
Compare
0d0f361
to
14805f5
Compare
e4cc638
to
e656d20
Compare
14805f5
to
8196916
Compare
e656d20
to
c80be85
Compare
8196916
to
fa3fae8
Compare
const fuse = new Fuse(commands, { | ||
keys: [{ name: 'label.title', weight: 2 }, 'label.subTitle'], | ||
includeMatches: true, | ||
includeScore: true, | ||
threshold: 0.4, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it better to wrap Fuse with a proper abstraction instead of accessing it directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a benefit, we can easily switch the underlying indexer engine and evaluate/compare the performance among them.
}), | ||
onStart(() => { | ||
this.items$.next([]); | ||
// loading |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems isLoading$ should be used here
} | ||
} | ||
|
||
const docs = await this.docSearchService.search(query); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think if it is a good idea to emit the link result immediately in line 73?
867aa16
to
5a314d4
Compare
2c0c6bc
to
7c2e6c2
Compare
5a314d4
to
48781ac
Compare
7c2e6c2
to
9825a7c
Compare
48781ac
to
babae43
Compare
9825a7c
to
7576ff5
Compare
babae43
to
d62e151
Compare
7576ff5
to
4ccb5e9
Compare
d62e151
to
ebe09c4
Compare
4ccb5e9
to
db385be
Compare
ebe09c4
to
b88337b
Compare
3c17fd6
to
8a86fbd
Compare
b88337b
to
6b570e6
Compare
8a86fbd
to
0bc1be3
Compare
No description provided.