refactor(core): workbench

[EYHN]

Merge the right sidebar logic into the workbench. this can simplify our logic.

Previously we had 3 modules

• workbench
• right-sidebar (Control sidebar open&close)
• multi-tab-sidebar (Control tabs)

Now everything is managed in Workbench.

Behavioral changes

The sidebar button is always visible and can be opened at any time.
If there is no content to display, will be No Selection

Elements in the sidebar can now be defined asunmountOnInactive=false. Inactive sidebars are marked with display: none but not unmount, so the ChatPanel can always remain in the DOM and user input will be retained even if the sidebar is closed.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[EYHN]

• refactor(core): workbench #7355 👈
• canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6447019. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 6 targets

• nx test:coverage @affine/monorepo
• nx build @affine/server-native -- --target x86_64-unknown-linux-gnu --use-napi-cross
• nx build @affine/native -- --target x86_64-pc-windows-msvc --use-napi-cross
• nx build @affine/native -- --target x86_64-apple-darwin --use-napi-cross
• nx build @affine/native -- --target aarch64-apple-darwin --use-napi-cross
• nx build @affine/native -- --target x86_64-unknown-linux-gnu --use-napi-cross

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

Attention: Patch coverage is 15.87302% with 106 lines in your changes missing coverage. Please review.

Project coverage is 58.24%. Comparing base (d72dbe6) to head (6447019).

Files	Patch %	Lines
...d/core/src/modules/workbench/view/view-islands.tsx	33.33%	24 Missing ⚠️
...core/src/modules/workbench/view/workbench-root.tsx	12.00%	22 Missing ⚠️
...ontend/core/src/modules/workbench/entities/view.ts	0.00%	15 Missing ⚠️
...d/core/src/modules/workbench/entities/workbench.ts	0.00%	14 Missing ⚠️
...dules/workbench/view/sidebar/sidebar-container.tsx	6.66%	14 Missing ⚠️
...ore/src/modules/workbench/view/route-container.tsx	0.00%	6 Missing ⚠️
...workbench/view/sidebar/sidebar-header-switcher.tsx	14.28%	6 Missing ⚠️
...ontend/core/src/modules/workbench/services/view.ts	0.00%	3 Missing ⚠️
...onent/src/components/resize-panel/resize-panel.tsx	0.00%	1 Missing ⚠️
...core/src/modules/workbench/entities/sidebar-tab.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           canary    #7355   +/-   ##
=======================================
  Coverage   58.23%   58.24%           
=======================================
  Files         856      853    -3     
  Lines       37735    37746   +11     
  Branches     4087     4086    -1     
=======================================
+ Hits        21976    21984    +8     
- Misses      15466    15469    +3     
  Partials      293      293           

Flag	Coverage Δ
server-test	77.91% <ø> (ø)
unittest	28.34% <15.87%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pengx17]

can you update the description on the purpose of changes?

[CatsJuice]

🤔 Why not keep Sidebar entity but manage in view directly?

[EYHN]

I deleted the sidebar, and the sidebar is now managed by the view

[CatsJuice]

Yes, I meant that is it more intuitive to maintain a Sidebar entity for the logic of the sidebar, as view.sidebar?

[EYHN]

can you update the description on the purpose of changes?

Simplified the logic of the sidebar, which was a bit over-designed before.

And now that the sidebar is included in the workbench, their states can also be saved and persisted together.