Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): adjust orm api #7392

Merged
merged 1 commit into from
Jul 1, 2024
Merged

feat(core): adjust orm api #7392

merged 1 commit into from
Jul 1, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Jul 1, 2024

Removed the connect and disconnect functions on the orm DBAdapter, making the ORM completely non-asynchronous.

Copy link

graphite-app bot commented Jul 1, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

EYHN commented Jul 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added mod:infra Environment related issues and discussions test Related to test cases labels Jul 1, 2024
Copy link

nx-cloud bot commented Jul 1, 2024

@EYHN EYHN marked this pull request as ready for review July 1, 2024 05:31
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.26%. Comparing base (d72dbe6) to head (39acb51).

Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #7392       +/-   ##
===========================================
- Coverage   58.23%   28.26%   -29.97%     
===========================================
  Files         856      656      -200     
  Lines       37735    14960    -22775     
  Branches     4087     2633     -1454     
===========================================
- Hits        21976     4229    -17747     
+ Misses      15466    10488     -4978     
+ Partials      293      243       -50     
Flag Coverage Δ
server-test ?
unittest 28.26% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Jul 1, 2024

Merge activity

Removed the `connect` and `disconnect` functions on the orm `DBAdapter`, making the ORM completely non-asynchronous.
@graphite-app graphite-app bot merged commit 39acb51 into canary Jul 1, 2024
32 checks passed
@graphite-app graphite-app bot deleted the eyhn/feat/orm-sync branch July 1, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod:infra Environment related issues and discussions test Related to test cases
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

3 participants