Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): adjust center peek animation #7393

Draft
wants to merge 2 commits into
base: canary
Choose a base branch
from

Conversation

CatsJuice
Copy link
Member

No description provided.

Copy link

graphite-app bot commented Jul 1, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Jul 1, 2024

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 2.02020% with 97 lines in your changes missing coverage. Please review.

Project coverage is 57.14%. Comparing base (c62d79a) to head (3c6ff92).

Files Patch % Lines
...ore/src/modules/peek-view/view/modal-container.tsx 0.00% 81 Missing ⚠️
...d/core/src/modules/peek-view/entities/peek-view.ts 0.00% 8 Missing ⚠️
.../src/modules/peek-view/view/peek-view-controls.tsx 0.00% 5 Missing ⚠️
...e/src/modules/peek-view/view/peek-view-manager.tsx 0.00% 2 Missing ⚠️
...src/modules/peek-view/view/image-preview/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7393      +/-   ##
==========================================
- Coverage   57.23%   57.14%   -0.10%     
==========================================
  Files         902      902              
  Lines       39401    39459      +58     
  Branches     4417     4430      +13     
==========================================
- Hits        22552    22549       -3     
- Misses      16497    16555      +58     
- Partials      352      355       +3     
Flag Coverage Δ
server-test 77.86% <ø> (-0.05%) ⬇️
unittest 28.89% <2.02%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice CatsJuice force-pushed the catsjuice/feat/center-peek-animation branch from e222b2f to c33d9d9 Compare July 1, 2024 07:34
@CatsJuice CatsJuice force-pushed the catsjuice/feat/center-peek-animation branch from c33d9d9 to 3c6ff92 Compare July 2, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

1 participant