Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy share link to clipboard command display issue #7411

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Jul 2, 2024

fix AF-1027

@pengx17 pengx17 marked this pull request as ready for review July 2, 2024 14:24
Copy link
Collaborator Author

pengx17 commented Jul 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

Copy link

graphite-app bot commented Jul 2, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

nx-cloud bot commented Jul 2, 2024

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 57.24%. Comparing base (b8b30e7) to head (ef7ba27).

Files Patch % Lines
...end/core/src/modules/quicksearch/impls/commands.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7411      +/-   ##
==========================================
+ Coverage   57.21%   57.24%   +0.03%     
==========================================
  Files         902      902              
  Lines       39421    39421              
  Branches     4425     4425              
==========================================
+ Hits        22553    22567      +14     
+ Misses      16516    16499      -17     
- Partials      352      355       +3     
Flag Coverage Δ
server-test 77.91% <ø> (ø)
unittest 28.99% <0.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Jul 2, 2024

Merge activity

Copy link
Member

@CatsJuice CatsJuice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a little strange to bind shortcut via invisible CMDK command. And F has the same issue.

@pengx17 pengx17 force-pushed the 07-02-fix_copy_share_link_to_clipboard_command_display_issue branch from 692e6e2 to ef7ba27 Compare July 2, 2024 15:28
Copy link
Collaborator Author

pengx17 commented Jul 2, 2024

It's a little strange to bind shortcut via invisible CMDK command. And ⌘ F has the same issue.

registerAffineCommand is designed to register command to affine. CMDK panel is one way to show the registered commands but may not be the only way.

I think registering keybinding here make things more flexible and maintainable. Keybinding should always be related to individual commands. Having a standalone keybinding registery seems not to be too beneficial.

@graphite-app graphite-app bot merged commit ef7ba27 into canary Jul 2, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 07-02-fix_copy_share_link_to_clipboard_command_display_issue branch July 2, 2024 15:42
forehalo pushed a commit that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

3 participants