-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: copy share link to clipboard command display issue #7411
fix: copy share link to clipboard command display issue #7411
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ef7ba27. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #7411 +/- ##
==========================================
+ Coverage 57.21% 57.24% +0.03%
==========================================
Files 902 902
Lines 39421 39421
Branches 4425 4425
==========================================
+ Hits 22553 22567 +14
+ Misses 16516 16499 -17
- Partials 352 355 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merge activity
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a little strange to bind shortcut via invisible CMDK command. And ⌘
F
has the same issue.
692e6e2
to
ef7ba27
Compare
registerAffineCommand is designed to register command to affine. CMDK panel is one way to show the registered commands but may not be the only way. I think registering keybinding here make things more flexible and maintainable. Keybinding should always be related to individual commands. Having a standalone keybinding registery seems not to be too beneficial. |
fix AF-1027