Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Name / parent variant of event!() #2983

Open
wants to merge 1 commit into
base: v0.1.x
Choose a base branch
from
Open

fix Name / parent variant of event!() #2983

wants to merge 1 commit into from

Conversation

Mododo
Copy link

@Mododo Mododo commented May 27, 2024

I'm on tracing v0.1.40 and cannot use macro

tracing::event!(name: "name", parent: &span, Level::ERROR, "foo")

and its variants (debug!(), etc) due to error

no method named `is_enabled` found for struct `DefaultCallsite` in the current scope

Looks like it was just missed out by accident

@Mododo Mododo requested review from hawkw and a team as code owners May 27, 2024 15:56
@Mododo Mododo mentioned this pull request May 27, 2024
Open
kaffarell
kaffarell approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@kaffarell kaffarell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Maybe add this trailer to the commit:

Fixes: 45a5df13735e ("core: add a limited form of the linked-list callsite registry for v0.1.x (#2083)")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaffarell kaffarell kaffarell approved these changes

@hawkw hawkw Awaiting requested review from hawkw hawkw is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mododo @kaffarell