Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Function to check user-specified grid #16

Merged
merged 9 commits into from
Feb 23, 2019
Merged

[WIP] Function to check user-specified grid #16

merged 9 commits into from
Feb 23, 2019

Conversation

tommyod
Copy link
Owner

@tommyod tommyod commented Feb 19, 2019 •
edited
Loading

This PR does the following:

  • Adds a Cython function grid_is_sorted which verifies that a grid is sorted.
  • Verifies that a grid is sorted when used with FFTKDE. No option to turn this check off, since we assume the number of grid points is much smaller than the number of data points, and the bottleneck is iterating over the data points.
  • Adds unit tests and regression tests directly tied to inconsistent behavior when using custom grid #15 .

@tommyod tommyod merged commit 116072e into master Feb 23, 2019
@tommyod tommyod deleted the add_grid_checking branch February 23, 2019 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inconsistent behavior when using custom grid
1 participant
@tommyod