Add multi-isotp and error checking to CAN-FD #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge upstream
code to be more memory efficient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You may not want to merge this all as-is. It's kind of messy and multiple items. But, if any of this is desirable I could create multiple pull requests.
Two big changes:
The isotp code now supports 16 independent streams instead of one. For some things, like in my case an ECU, you want to be able to handle multiple streams at once
Previously the error checking code only worked on CAN1 and CAN2 but I implemented it for CAN3 as well now. Also, I reorganized the CAN_error_t struct to be more memory efficient and put the strings into const memory outside the struct to also save more space.