Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config overhaul: add version and namespace to the configuration #947

Conversation

josecelano
Copy link
Member

@josecelano josecelano commented Jul 2, 2024

Add version to the configuration. It will fail if the provided version is not supported.

version = "2"

It only supports the exact match '2'.

@josecelano josecelano force-pushed the 937-config-overhaul-add-version-and-namespace-to-the-configuration branch from 110b9b2 to b946f9e Compare July 2, 2024 07:25
@josecelano josecelano added this to the v3.0.0 milestone Jul 2, 2024
@josecelano josecelano linked an issue Jul 2, 2024 that may be closed by this pull request
@josecelano josecelano requested a review from da2ce7 July 2, 2024 07:25
@josecelano josecelano self-assigned this Jul 2, 2024
@josecelano josecelano force-pushed the 937-config-overhaul-add-version-and-namespace-to-the-configuration branch from b946f9e to a548e29 Compare July 2, 2024 07:27
Add version and namespace to the configuration. It will fail if the provided version is not supported.

```toml
version = "2"
```

It only supports the exact match '2'.
@josecelano josecelano force-pushed the 937-config-overhaul-add-version-and-namespace-to-the-configuration branch from a548e29 to 60c6876 Compare July 2, 2024 07:28
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 77.36%. Comparing base (ddd73ca) to head (60c6876).

Files Patch % Lines
packages/configuration/src/lib.rs 67.85% 9 Missing ⚠️
packages/configuration/src/v2/mod.rs 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #947      +/-   ##
===========================================
- Coverage    77.40%   77.36%   -0.04%     
===========================================
  Files          183      183              
  Lines         9675     9707      +32     
===========================================
+ Hits          7489     7510      +21     
- Misses        2186     2197      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josecelano
Copy link
Member Author

ACK 60c6876

@josecelano josecelano merged commit 1e891f1 into torrust:develop Jul 2, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config overhaul: add version and namespace to the configuration
1 participant