firmware: add 2.7.2 #77
Conversation
| { | ||
| "required": false, | ||
| "version": [2, 7, 2], | ||
| "min_bridge_version": [2, 0, 7], |
There was a problem hiding this comment.
We removed min_bridge_version from releases.json in Suite some time ago because it was not used. Do you think it is used somewhere else or should we remove it from this repo as well? I can do it in another PR.
There was a problem hiding this comment.
Firmware doesn't use any data from here AFAIK. I don't know who else is consuming data from this repo.
| "bootloader_version": [2, 1, 4], | ||
| "translations": ["cs-CZ", "de-DE", "es-ES", "fr-FR"], | ||
| "url": "data/firmware/2/trezor-2.7.2.bin", | ||
| "url_bitcoinonly": "data/firmware/2/trezor-2.7.2-bitcoinonly.bin", |
There was a problem hiding this comment.
i'm thinking we should just point to t2t1 directory here, perhaps even make this releases.json a straight up copy of the t2t1 version ... and then not place new releases in the 2/ subdir.
what do you think @komret @vdovhanych ?
There was a problem hiding this comment.
This directory is not accessed by Suite, not even old versions, AFAIK. I suppose old versions of trezorctl use releases.json from here? If that is the only use case, then it could indeed point to the t2t1 directory instead.
There was a problem hiding this comment.
and yet, you merged with this thing untouched :) well there's always next time i suppose
There was a problem hiding this comment.
I'll do a separate PR.
@vdovhanych, could we just redirect from https://data.trezor.io/firmware/2/releases.json to https://data.trezor.io/firmware/t2t1/releases.json? Or do we have to maintain a copy of the file?
Changelog: