Improve Unikraft support in build files #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace error-prone copying of configuration file with the use of a defconfig file. Add `defconfigs/qemu-x86_64` and use `make defconfig` option in `Makefile.unikernel`. Signed-off-by: Razvan Deaconescu <[email protected]>
Move file generation rules (.config, model.h, tokenizer.h) out of `Makefile.unikernel` and into `Makefile`. This simplifies `Makefile.unikernel` making it Unikraft-specific. And making it easy to reuse as part of `make -f Makefile.unikraft ...` rules. Signed-off-by: Razvan Deaconescu <[email protected]>
razvand
force-pushed
the
razvand/improve-unikraft-support
branch
from
91a2d19
to
9d51600
Compare
trholding
approved these changes
Oct 9, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some parts of the build process are error-prone and do not perfectly fit into the Unikraft build model. Update
MakefileandMakefile.unikernelto improve the build process for Unikraft.