add speculative decoding example #432
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiaobingSuper
force-pushed
the
xiaobing/sp_decode
branch
from
7969195
to
a9076f8
Compare
XiaobingSuper
force-pushed
the
xiaobing/sp_decode
branch
from
a9076f8
to
8ebf94d
Compare
|
@Shixiaowei02, could you help review this PR? |
|
@XiaobingSuper did you test that this actually works? |
Yes, I checked and it works. |
|
Hi Xiaobing, great job! I've done similar things as you do, and sucessfully run sps (speculative sampling). It works fine for tp=1, but when tp=4 tritonserver will occasionlly block, and no log is printed. Do you encounter similar issue? The issue is detailed here: Thanks~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about adding a speculative decoding example.