Add basic testing for the tutorial #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmccorm4
reviewed
May 1, 2024
Conceptual_Guide/Part_7-iterative_scheduling/tests/test_iterative_scheduler.py
Show resolved
Hide resolved
rmccorm4
reviewed
May 1, 2024
| import time | ||
| import unittest | ||
|
|
||
| from tritonserver import InferenceRequest, Model, Server |
There was a problem hiding this comment.
Nice use of in-process Python API for testing! This is super simple and clean 🚀
rmccorm4
previously approved these changes
May 1, 2024
nnshah1
reviewed
May 2, 2024
Conceptual_Guide/Part_7-iterative_scheduling/tests/test_iterative_scheduler.py
Outdated
Show resolved
Hide resolved
nnshah1
reviewed
May 2, 2024
|
|
||
| def test_max_tokens(self): | ||
| self._infer_and_verify_request( | ||
| 32, |
There was a problem hiding this comment.
suggestion: make 32 a local constant,
suggestion: make the model name as a parameterized test:
https://realpython.com/pytest-python-testing/#parametrization-combining-tests
There was a problem hiding this comment.
parameterized doesn't work with unittest classes.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| import time | ||
| import unittest | ||
|
|
||
| import pytest |
Check notice
Code scanning / CodeQL
Unused import Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
triton-inference-server/server#7176