Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multimodal parser uses model gateway, replaced logger.error with logger.exception in try-catch #258

Merged
merged 5 commits into from
Jul 1, 2024
Merged

Multimodal parser uses model gateway, replaced logger.error with logger.exception in try-catch #258

merged 5 commits into from
Jul 1, 2024
+110 −98

Conversation

S1LV3RJ1NX
Copy link
Collaborator

No description provided.

@S1LV3RJ1NX S1LV3RJ1NX changed the title Multimodal parser uses, replaced logger.error with logger.exception in try-catch Multimodal parser uses model gateway, replaced logger.error with logger.exception in try-catch Jun 27, 2024
chiragjn
chiragjn approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@chiragjn chiragjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping it in approved state, but added a few comments

@S1LV3RJ1NX S1LV3RJ1NX merged commit 948af97 into main Jul 1, 2024
1 check passed
@S1LV3RJ1NX S1LV3RJ1NX deleted the ps_multimodal_parser_refactor branch July 1, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiragjn chiragjn chiragjn approved these changes

@innoavator innoavator Awaiting requested review from innoavator

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@S1LV3RJ1NX @chiragjn