Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: null year-month for pharmacy in PMPM #512

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Conversation

sarah-tuva
Copy link
Member

Describe your changes

Resolves #452.

  • removed incorrect date cast causing nulls for pharmacy claims
  • refactored formatting to match style guide

How has this been tested?

Ran dbt build and validated output. Pharmacy claims have year_month populated now.

Reviewer focus

Please summarize the specific items you’d like the reviewer(s) to look into.

Checklist before requesting a review

  • I have added at least one Github label to this PR (bug, enhancement, breaking change,...)
  • My code follows style guidelines
  • (New models) YAML files are categorized by sub folder and models listed in alphabetical order
  • (New models) I have added a config to each new model to enable it for claims and/or clinical data
  • (New models) I have added the variable tuva_last_run to the final output
  • (Optional) I have recorded a Loom to explain this PR

Package release checklist

  • I have updated dbt docs
  • I have updated the version number in the dbt_project.yml

(Optional) Gif of how this PR makes you feel

Loom link

@sarah-tuva sarah-tuva added the bug Something isn't working label Jun 26, 2024
@sarah-tuva sarah-tuva changed the title Bug fix pmpm pharmacy BUGFIX: null year-month for pharmacy in PMPM Jun 26, 2024
Copy link
Member

@thutuva thutuva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thutuva thutuva merged commit eb7ad0d into main Jun 26, 2024
5 checks passed
@thutuva thutuva deleted the bug-fix-pmpm-pharmacy branch June 26, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date casting issue causes silent errors in redshift
2 participants