Add and declare missing peer dependencies #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `npm install`, with a recent version of npm, triggers a fix up which add metadata in the lock file. Here is the output : $ npm install npm WARN old lockfile npm WARN old lockfile The package-lock.json file was created with an old version of npm, npm WARN old lockfile so supplemental metadata must be fetched from the registry. npm WARN old lockfile npm WARN old lockfile This is a one-time fix-up, please be patient... npm WARN old lockfile npm WARN deprecated [email protected]: The querystring API is considered Legacy. new code should use the URLSearchParams API instead. added 8 packages, removed 33 packages, changed 25 packages, and audited 1039 packages in 23s
- @babel/runtime is requested by typesense-instantsearch-adapter and typesense. - algoliasearch is requested by algoliasearch-helper.
…atiblity with the future releases
jasonbosco
reviewed
May 20, 2022
| "@docusaurus/utils-validation": "2.0.0-beta.17", | ||
| "@docusaurus/utils": "~2.0.0-beta.17", | ||
| "@docusaurus/utils-validation": "~2.0.0-beta.17", | ||
| "algoliasearch": "^4.13.0", |
There was a problem hiding this comment.
@romdej algoliasearch is actually not a required dependency. It's probably set as a peer dependency in another dependency, when it should really be an optional peer dependency...
| @@ -32,10 +33,11 @@ | |||
| "typesense-instantsearch-adapter": "^2.4.0" | |||
| }, | |||
| "peerDependencies": { | |||
| "@babel/runtime": "^7.17.9", | |||
There was a problem hiding this comment.
@babel/runtime should also be set as an optional peer dependency because projects could have some other transpiration mechanism built-in, like in the case of docusaurus.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Some peer dependencies were missing in the package.json. This resulted in warnings during the installation of the package. So I added the missing dependencies for a better developper experience. The added dependencies are:
I've also updated the versions of the docusaurus dependencies to allow a compatibility with more versions of docusaurus.
PR Checklist