Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bone-resume:0.2.0 #786

Merged
merged 4 commits into from
Jul 4, 2024
Merged

bone-resume:0.2.0 #786

merged 4 commits into from
Jul 4, 2024

Conversation

zrr1999
Copy link
Contributor

@zrr1999 zrr1999 commented Jul 3, 2024

I am submitting

  • a new package
  • an update for a package

Description: BoneResume is a resume template for Typst.

I have read and followed the submission guidelines and, in particular, I

  • selected a name that isn't the most obvious or canonical name for what the package does
  • added a typst.toml file with all required keys
  • added a README.md with documentation for my package
  • have chosen a license and added a LICENSE file or linked one in my README.md
  • tested my package locally on my system and it worked
  • excluded PDFs or README images, if any, but not the LICENSE
  • ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

Copy link
Contributor

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small naming suggestion, otherwise it looks good.

body
}

#let primary_achievement(name, decs, contrib) = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be consistent with other functions, you may want to rename that one to primary-achievement.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, it has been modified, thank you.

@elegaanz
Copy link
Contributor

elegaanz commented Jul 4, 2024

Thanks :)

@elegaanz elegaanz merged commit ade6c52 into typst:main Jul 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants