Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing Test Coverage #2769

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Increasing Test Coverage #2769

merged 4 commits into from
Mar 21, 2024

Conversation

HimanshiVerma05
Copy link

@HimanshiVerma05 HimanshiVerma05 commented Mar 20, 2024

Checklist
  • the [individual contributor license agreement][] is signed
  • commit message follows [commit guidelines][]
  • tests are included
Description of change

Increased the code test coverage by adding new test cases .

Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @HimanshiVerma05!
Thanks for sharing new test cases!

When you have a chance could you apply the Google Java format to the code.
You could do this manually, or automatically with ./gradlew goJF.

@HimanshiVerma05
Copy link
Author

HimanshiVerma05 commented Mar 20, 2024

Welcome @HimanshiVerma05! Thanks for sharing new test cases!

When you have a chance could you apply the Google Java format to the code. You could do this manually, or automatically with ./gradlew goJF.

Hi @ChristianMurphy . Sure ! Let me do it right away!

@HimanshiVerma05
Copy link
Author

Hi @ChristianMurphy . Done !

Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HimanshiVerma05! 🙇

@ChristianMurphy ChristianMurphy merged commit 8ae62f2 into uPortal-Project:master Mar 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants