Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: add extra global share permission check #139

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Fix: add extra global share permission check #139

merged 2 commits into from
Jun 7, 2024

Conversation

pieterlukasse
Copy link

@pieterlukasse pieterlukasse commented Jun 6, 2024 •
edited
Loading

Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/VADC-1191

Improvements

  • fix: add extra check to ensure user has global sharing permission

Dependency updates

  • with this change, sharing with public role (roleId == 1) can now only be done if the user has a specific "global sharing" permission AND the teamProject the user is currently logged in to has WRITE access to the item being shared

@pieterlukasse pieterlukasse force-pushed the fix/add_extra_global_share_permission_check branch from 430d306 to b2f763c Compare June 7, 2024 16:57
@pieterlukasse pieterlukasse force-pushed the fix/add_extra_global_share_permission_check branch from b2f763c to f80ae8f Compare June 7, 2024 18:18
@pieterlukasse pieterlukasse force-pushed the fix/add_extra_global_share_permission_check branch from f80ae8f to f05f872 Compare June 7, 2024 18:19
@pieterlukasse pieterlukasse merged commit cc74e1a into 2.15.0-DEV Jun 7, 2024
3 checks passed
@pieterlukasse pieterlukasse deleted the fix/add_extra_global_share_permission_check branch June 7, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m0nhawk m0nhawk m0nhawk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pieterlukasse @m0nhawk