Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add timeout to invalidate inactive sessions #148

Closed
wants to merge 5 commits into from

Conversation

pieterlukasse
Copy link

@pieterlukasse pieterlukasse commented Jul 4, 2024

Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/VADC-1241

Improvements

  • added timeout for sessions. This should invalidate inactive sessions after the timeout period
  • set the default timeout to 20 minutes

@pieterlukasse pieterlukasse force-pushed the feat/add_global_timeout_setting branch from 8e99aa8 to 04d1ac9 Compare July 5, 2024 13:17
@pieterlukasse pieterlukasse force-pushed the feat/add_global_timeout_setting branch 2 times, most recently from 165029a to 90054e0 Compare July 5, 2024 18:38
@pieterlukasse pieterlukasse force-pushed the feat/add_global_timeout_setting branch from 90054e0 to a585f4b Compare July 5, 2024 18:49
@pieterlukasse
Copy link
Author

pieterlukasse commented Jul 11, 2024

feedback from WebAPI devs: why not use the existing security.token.expiration ?

Indeed, we could combine this Atlas setting configLocal.refreshTokenThreshold with the WebAPI security.token.expiration setting to achieve a behavior similar to session timeout.

@pieterlukasse
Copy link
Author

closed in favor of config changes proposed above

@pieterlukasse
Copy link
Author

reopening as security.token.expiration does not seem to be sufficient

@pieterlukasse
Copy link
Author

found alternative solution #151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant