Skip to content

Commit

Permalink
adding changes to give argo UI access to buckets so artifacts can be …
Browse files Browse the repository at this point in the history
…viewed in the UI (#2581)
  • Loading branch information
EliseCastle23 authored Jul 2, 2024
1 parent 0c84a51 commit f050dc8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 2 additions & 2 deletions gen3/bin/awsrole.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ gen3_load "gen3/gen3setup"
gen3_awsrole_help() {
gen3 help awsrole
}

#
# Assume-role policy - allows SA's to assume role.
# NOTE: service-account to role is 1 to 1
Expand Down Expand Up @@ -71,7 +70,8 @@ function gen3_awsrole_ar_policy() {
"${issuer_url}:aud": "sts.amazonaws.com",
"${issuer_url}:sub": [
"system:serviceaccount:*:${serviceAccount}",
"system:serviceaccount:argo:default"
"system:serviceaccount:argo:default",
"system:serviceaccount:argo:argo-argo-workflows-server"
]
}
}
Expand Down
2 changes: 2 additions & 0 deletions gen3/bin/kube-setup-argo.sh
Original file line number Diff line number Diff line change
Expand Up @@ -188,11 +188,13 @@ EOF
roleArn=$(aws iam get-role --role-name "${roleName}" --query 'Role.Arn' --output text)
gen3_log_info "Role annotate"
g3kubectl annotate serviceaccount default eks.amazonaws.com/role-arn=${roleArn} --overwrite -n $argo_namespace
g3kubectl annotate serviceaccount argo-argo-workflows-server eks.amazonaws.com/role-arn=${roleArn} --overwrite -n $argo_namespace
g3kubectl annotate serviceaccount argo eks.amazonaws.com/role-arn=${roleArn} --overwrite -n $nameSpace
else
gen3 awsrole create $roleName argo $nameSpace -all_namespaces
roleArn=$(aws iam get-role --role-name "${roleName}" --query 'Role.Arn' --output text)
g3kubectl annotate serviceaccount default eks.amazonaws.com/role-arn=${roleArn} -n $argo_namespace
g3kubectl annotate serviceaccount argo-argo-workflows-server eks.amazonaws.com/role-arn=${roleArn} -n $argo_namespace
fi

# Grant access within the current namespace to the argo SA in the current namespace
Expand Down

0 comments on commit f050dc8

Please sign in to comment.