(HP-572) create dynamodb table for gen3-license workspace #2441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfshao
reviewed
Feb 13, 2024
gen3/bin/kube-setup-hatchery.sh
Outdated
| @@ -20,13 +20,64 @@ gen3 jupyter j-namespace setup | |||
| # | |||
| (g3k_kv_filter ${GEN3_HOME}/kube/services/hatchery/serviceaccount.yaml BINDING_ONE "name: hatchery-binding1-$namespace" BINDING_TWO "name: hatchery-binding2-$namespace" CURRENT_NAMESPACE "namespace: $namespace" | g3kubectl apply -f -) || true | |||
|
|
|||
|
|
|||
| # TODO: disable this cron-job after hatchery is updated to the dynamoDB version | |||
There was a problem hiding this comment.
I think we can move this block of logic that sets up the distribute-licenses cronjob into the if block at https://github.com/uc-cdis/cloud-automation/pull/2441/files#diff-60cb659c9ec13c9256d2140bfb074068431ad6177cfe217baf6ee5210c125d04R74
This way we could maintain the backward compatibility but not creating this cronjob if the new config is in place
We will be eventually removing this part of logic soon from this script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: HP-572
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes