Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating the cedar data ingest #2472

Merged
merged 12 commits into from
Feb 29, 2024
Merged

Conversation

MichaelLukowski
Copy link
Member

@MichaelLukowski MichaelLukowski commented Feb 16, 2024

Jira Ticket: HP-1343

New Features

Updates to the heal cedar ingestion script

added logic for heal_platform_citation, repository_study_link, repository_citation, and related studies

Copy link
Contributor

@mfshao mfshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, just two minor comments



# repository links
REPOSITORY_STUDY_ID_LINK_TEMPLATE = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be better if we move this constant def to the top of the file

.get("serial_num", None)
)
except Exception:
print(f"Unable to get serial number for study")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also print this if serial_num == None

Copy link
Contributor

@mfshao mfshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelLukowski MichaelLukowski merged commit 6c27fc9 into master Feb 29, 2024
6 of 7 checks passed
@MichaelLukowski MichaelLukowski deleted the feat/cedar-ingestion-update branch February 29, 2024 15:59
mfshao added a commit that referenced this pull request Mar 1, 2024
mfshao added a commit that referenced this pull request Mar 1, 2024
* Revert "fix missed import (#2491)"

This reverts commit bd6bc76.

* Revert "Update heal-cedar-data-ingest.py (#2490)"

This reverts commit 90b6609.

* Revert "updating the cedar data ingest (#2472)"

This reverts commit 6c27fc9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants