Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove Atlas/WebAPI configuration, not needed, it's exposed via ALB #2575

Merged
merged 1 commit into from
Jun 21, 2024
Merged

feat: remove Atlas/WebAPI configuration, not needed, it's exposed via ALB #2575

merged 1 commit into from
Jun 21, 2024

Conversation

m0nhawk
Copy link
Contributor

@m0nhawk m0nhawk commented Jun 20, 2024

Link to JIRA ticket if there is one: N/A

New Features

Breaking Changes

Bug Fixes

Improvements

  • removing unneeded nginx configuration

Dependency updates

Deployment changes

pieterlukasse
pieterlukasse approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@pieterlukasse pieterlukasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. Where is the real setting to be found then?

@m0nhawk
Copy link
Contributor Author

m0nhawk commented Jun 21, 2024

@pieterlukasse Atlas service is exposed directly via ALB, so this: https://github.com/uc-cdis/Atlas/blob/2.15.0-DEV/docker/nginx-default.conf

@m0nhawk m0nhawk merged commit cbc2b69 into master Jun 21, 2024
3 of 5 checks passed
@m0nhawk m0nhawk deleted the feat/atlas branch June 21, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieterlukasse pieterlukasse pieterlukasse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m0nhawk @pieterlukasse