Feat/backup script #2604
Merged
Feat/backup script #2604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emalinowski
previously approved these changes
Aug 9, 2024
jawadqur
reviewed
Aug 12, 2024
gen3/bin/dbbackup.sh
Outdated
| create_or_get_kms_key | ||
| create_s3_bucket $bucket_name $kms_key_arn | ||
| create_s3_bucket $bucket_name_encrypted $kms_key_arn | ||
| setup_csi_driver |
There was a problem hiding this comment.
Ideally this should be a separate script or terraform. Then we can call that separate script or terraform from within this script.
gen3/bin/dbbackup.sh
Outdated
|
|
||
| gen3_log_info "policy_name: $policy_name" | ||
| gen3_log_info "account_id: $account_id" | ||
| gen3_log_info "vpc_name: $vpc_name" | ||
| gen3_log_info "namespace: $namespace" | ||
| gen3_log_info "sa_name: $sa_name" | ||
| gen3_log_info "bucket_name: $bucket_name" |
There was a problem hiding this comment.
We should not need a unencrypted bucket, we should only allow an encrypted bucket.
gen3/bin/dbbackup.sh
Outdated
| } | ||
|
|
||
| # Create policy for Mountpoint for Amazon S3 CSI driver | ||
| create_s3_csi_policy() { |
There was a problem hiding this comment.
Same thing for all these other functions related to csi driver. These should go into a kube-setup-s3-csi or similar script, and then this script can call that other script, we need to make sure the other script is idempotent as well.
fix tmp file name
added service account creation
Add all oidc_url's to the trust plicy
separate policies, roles per cluster
emalinowski
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install mount-s3