Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PPS-588 guppy csrf #1464

Merged
merged 8 commits into from
Dec 20, 2023
Merged

PPS-588 guppy csrf #1464

merged 8 commits into from
Dec 20, 2023

Conversation

mfshao
Copy link
Collaborator

@mfshao mfshao commented Dec 14, 2023 •
edited by jira bot
Loading

Jira Ticket: PPS-588

Bug fixes

  • Fixed a bug about misconfigured webpack publicPath

Improvements

  • Use new Guppy version which supports handling with CSRF tokens
  • Ensure CSRF token is passed to Guppy

Dependency updates

  • Update Guppy to 0.18.0

Deployment changes

@mfshao mfshao changed the title guppy csrf PPS-588 guppy csrf Dec 15, 2023
@mfshao mfshao mentioned this pull request Dec 15, 2023
Merged
@mfshao mfshao marked this pull request as ready for review December 15, 2023 18:09
mfshao
mfshao commented Dec 15, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
MaribelleHGomez
MaribelleHGomez previously approved these changes Dec 15, 2023
View reviewed changes
Copy link

@MaribelleHGomez MaribelleHGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

k-burt-uch
k-burt-uch approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@k-burt-uch k-burt-uch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes since the last approval outside of updating the guppy dependency to a released version.

@mfshao mfshao merged commit 9b35888 into master Dec 20, 2023
8 checks passed
@mfshao mfshao deleted the fix/guppy-csrf branch December 20, 2023 15:26
PlanXCyborg pushed a commit that referenced this pull request Dec 21, 2023
@mfshao @PlanXCyborg
PPS-588 guppy csrf (#1464)
bb3af3d 
* guppy csrf

* update pkg

* update action

* update guppy

* update guppy

* update guppy

* fix return

* update pkg
This was referenced Jan 4, 2024
Merged
Merged
Merged
Merged
This was referenced Jan 30, 2024
Open
Merged
Merged
Merged
Merged
This was referenced Jan 31, 2024
Closed
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Open
Merged
@github-actions github-actions bot mentioned this pull request Feb 8, 2024
Merged
This was referenced Feb 16, 2024
Merged
Merged
Merged
Merged
@github-actions github-actions bot mentioned this pull request Mar 7, 2024
Open
@github-actions github-actions bot mentioned this pull request Mar 27, 2024
Merged
This was referenced May 8, 2024
Open
Open
@github-actions github-actions bot mentioned this pull request Jul 1, 2024
Open
@github-actions github-actions bot mentioned this pull request Jul 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-burt-uch k-burt-uch k-burt-uch approved these changes

@MaribelleHGomez MaribelleHGomez MaribelleHGomez left review comments

Assignees
No one assigned
Labels
test-portal-exportToWorkspaceTest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mfshao @MaribelleHGomez @k-burt-uch @PlanXCyborg