Do not use Provider component imported from jotai

udecode · Feb 28, 2024 · 96c08e9 · 96c08e9
1 parent 5b179fe
commit 96c08e9
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 14 deletions.
diff --git a/.changeset/cuddly-pets-tickle.md b/.changeset/cuddly-pets-tickle.md
@@ -0,0 +1,5 @@
+---
+'jotai-x': patch
+---
+
+Do not render jotai's Provider component as part of jotai-x's provider. Jotai's Provider is unnecessary and interferes with vanilla jotai atoms.
diff --git a/packages/jotai-x/src/atomProvider.ts b/packages/jotai-x/src/atomProvider.ts
diff --git a/packages/jotai-x/src/createAtomProvider.tsx b/packages/jotai-x/src/createAtomProvider.tsx
@@ -1,7 +1,6 @@
 import React from 'react';
 import { createStore } from 'jotai/vanilla';
 
-import { AtomProvider, AtomProviderProps } from './atomProvider';
 import { JotaiStore, SimpleWritableAtomRecord } from './createAtomStore';
 import { useHydrateStore, useSyncStore } from './useHydrateStore';
 
@@ -116,13 +115,11 @@ export const createAtomProvider = <T extends object, N extends string = ''>(
 
     return (
       <AtomStoreContext.Provider value={storeContext}>
-        <AtomProvider store={storeState}>
-          <HydrateAtoms store={storeState} atoms={atoms} {...(props as any)}>
-            {!!Effect && <Effect />}
+        <HydrateAtoms store={storeState} atoms={atoms} {...(props as any)}>
+          {!!Effect && <Effect />}
 
-            {children}
-          </HydrateAtoms>
-        </AtomProvider>
+          {children}
+        </HydrateAtoms>
       </AtomStoreContext.Provider>
     );
   };

diff --git a/packages/jotai-x/src/index.ts b/packages/jotai-x/src/index.ts
@@ -2,7 +2,6 @@
  * @file Automatically generated by barrelsby.
  */
 
-export * from './atomProvider';
 export * from './atomWithFn';
 export * from './createAtomProvider';
 export * from './createAtomStore';