Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use Provider component imported from jotai #11

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

12joan
Copy link
Collaborator

@12joan 12joan commented Feb 28, 2024

Description

Fixes #10

See changesets.

@12joan
Copy link
Collaborator Author

12joan commented Feb 28, 2024

/release:next

@12joan
Copy link
Collaborator Author

12joan commented Feb 28, 2024

/release:next

Copy link
Contributor

A new release has been made for this pull request.

@12joan
Copy link
Collaborator Author

12joan commented Feb 28, 2024

Confirmed fixes issue sandbox, and causes no test failures in Plate

@12joan 12joan marked this pull request as ready for review February 28, 2024 11:17
@12joan 12joan requested a review from zbeyens February 28, 2024 11:17
@valerio-pescatori
Copy link

@12joan can you make the sandbox public pls?
btw thank you for the quick fix!

@zbeyens zbeyens merged commit 5fb32bf into main Feb 28, 2024
1 check passed
@12joan 12joan deleted the fix/jotai-atom-provider-interfering-with-vanilla-atoms branch February 28, 2024 13:03
@12joan
Copy link
Collaborator Author

12joan commented Feb 28, 2024

@valerio-pescatori Sorry, I didn't know code sandboxes needed to be made public now. Here it is.

https://codesandbox.io/p/sandbox/jotai-x-broke-providerless-forked-r6vnw9?file=%2Fsrc%2FApp.tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jotai-x broke plain Jotai's provider-less atoms
3 participants