Skip to content

Commit

Permalink
fix: work with recent apsw
Browse files Browse the repository at this point in the history
It looks like from apsw 3.43.1.1 onwards, the virtual filesystem file needs the
xSectorSize function.

Nothing in the apsw changelog at https://rogerbinns.github.io/apsw/changes.html
makes this particular clear - the issue from 3.43.1.1 onwards was determined by
running the tests for sqlite-s3vfs for each apsw version.

The sector size of "0" for some reason is the only one that makes the rollback
tests pass

Thank you to https://github.com/blueshed for the report

Closes #24
  • Loading branch information
michalc committed Mar 13, 2024
1 parent 98da943 commit f94a862
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions sqlite_s3vfs.py
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,9 @@ def _read():

return b"".join(_read())

def xSectorSize(self):
return 0

def xFileControl(self, *args):
return False

Expand Down

0 comments on commit f94a862

Please sign in to comment.