Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tp2000 1327 upgrade python 3.12 #1246

Open
wants to merge 52 commits into
base: master
Choose a base branch
from

Conversation

mattjamc
Copy link
Collaborator

@mattjamc mattjamc commented Jun 13, 2024

TP2000-1327 Upgrade Python 3.12

Why

Upgrade Python to the latest version.

What

Following on from the PR to upgrade to 3.11, this PR:

  • Updates Python required to 3.12
  • Upgrades coverage from 5.4 to 7.4 [Solved various bdd tests that began failing and reduced test run time which had doubled]
  • Upgrades lxml from 4.9.1 to 5.2.2 [Unable to build lxml version 4.9.1 - Error: Please make sure the libxml2 and libxslt development packages are installed]
  • Following lmxl upgrade, makes bomb.xml file a bit longer to ensure it correctly raises the XMLSyntaxError
  • Upgrades moto from 2.1.0 to 3.0.7 [Resolve AttributeError: module 'ssl' has no attribute 'wrap_socket']
  • Following moto upgrade, accounts for BucketAlreadyOwnedByYou exception
  • Removes redundant test_workbasket_clean_does_not_run_business_rules
  • Upgrades pytest from 7.1.2 to 7.4.0 to get rid of new deprecation warnings
  • downgrades boto to stop this new error when sending a WB for packaging (botocore.exceptions.ClientError: An error occurred (PermanentRedirect) when calling the PutObject operation: The bucket you are attempting to access must be addressed using the specified endpoint. Please send all future requests to this endpoint.)
  • downgrades elastic-apm to prevent the following error when downloading an envelope ("failed to validate span: error validating JSON: I[#] S[#] doesn't validate with \"span#\"\n I[#] S[#/allOf/3] allOf failed\n I[#/context/tags] S[#/allOf/3/properties/context/properties/tags/additionalProperties] additionalProperties \"aws.s3.bucket\" not allowed)

@mattjamc mattjamc added the do not merge PR is not ready to be merged label Jun 21, 2024
@mattjamc mattjamc marked this pull request as ready for review June 21, 2024 15:08
@mattjamc mattjamc requested a review from a team as a code owner June 21, 2024 15:08
@mattjamc mattjamc closed this Jun 21, 2024
@mattjamc mattjamc reopened this Jun 21, 2024
@mattjamc mattjamc marked this pull request as draft June 21, 2024 15:10
@mattjamc mattjamc marked this pull request as ready for review June 24, 2024 13:21
@mattjamc mattjamc removed the do not merge PR is not ready to be merged label Jul 2, 2024
Copy link
Collaborator

@paulpepper-trade paulpepper-trade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of things on non-changed files:

  • Do the language_version values in .pre-commit-config.yaml need updating?
  • Can lines 50-61 in common/util.py be removed now?

Otherwise, LGTM!

common/tests/test_files/bomb.xml Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.09%. Comparing base (39be270) to head (0350440).
Report is 22 commits behind head on master.

Files Patch % Lines
workbaskets/tests/test_views.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1246      +/-   ##
==========================================
- Coverage   93.20%   93.09%   -0.11%     
==========================================
  Files         618      620       +2     
  Lines       46671    47433     +762     
  Branches     3308     5094    +1786     
==========================================
+ Hits        43499    44158     +659     
- Misses       2536     2630      +94     
- Partials      636      645       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants