TP2000-1269 Resolve uncontrolled data used in path expression alert #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalecannon
force-pushed
the
TP2000-1269--uncontrolled-data-path-expression-alert
branch
12 times, most recently
from
92eedc4
to
8ae72b4
Compare
dalecannon
force-pushed
the
TP2000-1269--uncontrolled-data-path-expression-alert
branch
from
8ae72b4
to
adbe367
Compare
dalecannon
force-pushed
the
TP2000-1269--uncontrolled-data-path-expression-alert
branch
from
adbe367
to
728afc5
Compare
dalecannon
commented
Jul 10, 2024
| "File name must only include alphanumeric characters and special characters such as spaces, hyphens and underscores.", | ||
| ) | ||
| validate_filename(uploaded_taric_file.name) | ||
| validate_filepath(uploaded_taric_file) | ||
|
|
||
| try: | ||
| xml_file = parse_xml(uploaded_taric_file) |
There was a problem hiding this comment.
Despite the current validation (and after various other validation attempts), one CodeQL alert warning that uploaded_taric_file is an uncontrolled user input still remains.
It may just be a false positive, where the scanner overlooks how we're having to access the name attribute on the InMemoryUploadedFile object to validate its filename, and not a str or other such object that can be directly acted upon to satisfy the scanner's expectations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TP2000-1269 Resolve uncontrolled data used in path expression alert
Why
The filenames of TARIC files uploaded in the importer form could use some validation and sanitisation.
What
validate_filenameandvalidate_filepath, that can be used to guard against malicious filenames and path traversal attacksImportBatchbased on the uploaded TARIC file