Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP2000-1436 Serialize Measure Edit Forms - DRAFT - DNM #1258

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

LaurenMullally
Copy link
Contributor

TP2000-1436 Serialize Measure Edit Forms

Why

The first part in a 4 ticket saga to get the Bulk Measure Edit process to be asyncronous.

What I have done so far:

  • Added SerializableFormMixin to all the forms in the Measure Edit journey in order to give them serializing functionality.
  • Split the form list into form_list and data_form_list to match the convention with measure create, but also to help the serializing functionality skip the forms that don't give us any data.
  • Copied and pasted .all_serializable_form_data() and .all_serializable_form_kwargs() and all their little sub functions from the measure create wizard into the measure edit wizard.. This will need refactoring later but not a probb for now

What needs doing:

  • Geographical area exclusions or whoever she is, isn't playing ball. Might be a good idea to ask Paul about this, as it caused a problem in the MeasureCreate journey too. Something about prefixes as it's a form within a formset etc..
  • Tests need writing just to check that the data we serialize is what we expect it to be. There will be really similar tests on the MeasureCreate journey (probably, not looked yet.. not v tdd of me 😬 ) but if it doesn't make sense to re write the wheel (aka the tests are isolated just for that function which we'll be sharing across both measures in the future anyway) then perhaps it doesn't need them as we're only merging this to the mega branch so it's nbd surely!

Ps thank you Matt for helping with this! appreciate you!

@LaurenMullally LaurenMullally added the do not merge PR is not ready to be merged label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge PR is not ready to be merged
Projects
None yet
2 participants