Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR on language to help disambiguate removing items from the workbasket vs deleting items from the tariff. #552

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stuaxo
Copy link
Contributor

@stuaxo stuaxo commented May 9, 2022

This ADR proposes using language to distinguish between the tasks "remove item from workbasket" and "delete item from tariff" by using that language instead of just the term "Delete".

…e workbasket vs "delete" to delete trackedmodels from the tariff.
@codecov-commenter
Copy link

Codecov Report

Merging #552 (af237df) into master (0f2ff16) will decrease coverage by 0.06%.
The diff coverage is 96.77%.

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
- Coverage   92.74%   92.67%   -0.07%     
==========================================
  Files         306      319      +13     
  Lines       19066    19679     +613     
  Branches     1526     1573      +47     
==========================================
+ Hits        17682    18237     +555     
- Misses       1107     1145      +38     
- Partials      277      297      +20     
Impacted Files Coverage Δ
common/models/transactions.py 87.75% <ø> (+2.93%) ⬆️
settings/common.py 75.83% <40.00%> (-1.41%) ⬇️
geo_areas/forms.py 80.00% <50.00%> (-3.88%) ⬇️
workbaskets/models.py 85.55% <75.00%> (-1.26%) ⬇️
workbaskets/tasks.py 86.36% <76.92%> (-13.64%) ⬇️
checks/models.py 93.54% <93.54%> (ø)
checks/tests/test_checkers.py 94.44% <94.44%> (ø)
checks/tasks.py 97.10% <97.10%> (ø)
checks/checks.py 97.50% <97.50%> (ø)
checks/tests/factories.py 97.82% <97.82%> (ø)
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f5f88e...af237df. Read the comment docs.

@stuaxo stuaxo changed the title ADR proposing the use of "remove" when removing trackedmodels from th… ADR on language to help disambiguate removing items from the workbasket vs deleting items from the tariff. Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants