Fix for list_workbaskets to accept multiple workbasket ids. #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split out dump_transactions main method so it can be called from notebooks more convieniently.
Codecov Report
@@ Coverage Diff @@
## master #668 +/- ##
==========================================
+ Coverage 93.36% 93.44% +0.07%
==========================================
Files 324 325 +1
Lines 20822 21124 +302
Branches 1658 1672 +14
==========================================
+ Hits 19441 19739 +298
+ Misses 1067 1063 -4
- Partials 314 322 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
stuaxo
force-pushed
the
management-command-changes
branch
from
ed45953
to
3ad256c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out dump_transactions main method so it can be called from notebooks more conveniently.
Fix for list_workbaskets to accept multiple workbasket ids.
(Note: We should probably make all the commands that accept workbaskets accept comma separated lists of ids!)
Ensure to actually test, I noticed the list_workbaskets change and added but don't have time to double check, the dump_transactions change is basically just eyeballed as don't have time to double check before going, but I think this is probably a better way of using this from notebooks than the current way of grabbing the Command internals, so even if it doesn't work it may be worth making work.